Skip to content

[Devtools] Update Readme Links #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Jdubrick
Copy link
Contributor

This PR updates the README so that the links direct the user to the correct block of code. Previous to this PR some links were containing irrelevant lines of code.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link
Contributor

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revise v2 branch with these corrections as well: https://github.com/devfile-samples/devfile-sample-python-basic/tree/v2.0.0

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@michael-valdron
Copy link
Contributor

michael-valdron commented Feb 29, 2024

You'll need to revise v2 branch with these corrections as well: https://github.com/devfile-samples/devfile-sample-python-basic/tree/v2.0.0

I re-mend my original request for the v2 branch changes, since the setup on the v2 branch is different we'll need a rewrite to explain the v2 setup with the reference links pointing to the v2 branch files or parent devfile.

cc: @Jdubrick

Copy link
Contributor

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jdubrick Jdubrick merged commit 61e1983 into devfile-samples:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants